> -----Original Message----- > From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx] > Sent: Thursday, October 5, 2017 3:50 AM > To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx> > Cc: dvhart@xxxxxxxxxxxxx; LKML <linux-kernel@xxxxxxxxxxxxxxx>; Platform Driver > <platform-driver-x86@xxxxxxxxxxxxxxx>; Andy Lutomirski <luto@xxxxxxxxxx>; > quasisec@xxxxxxxxxx; Pali Rohár <pali.rohar@xxxxxxxxx>; Rafael J. Wysocki > <rjw@xxxxxxxxxxxxx>; mjg59@xxxxxxxxxx; Christoph Hellwig <hch@xxxxxx>; > Greg KH <greg@xxxxxxxxx> > Subject: Re: [PATCH v4 08/14] platform/x86: dell-smbios: Add a sysfs interface for > SMBIOS tokens > > On Thu, Oct 5, 2017 at 1:48 AM, Mario Limonciello > <mario.limonciello@xxxxxxxx> wrote: > > Currently userspace tools can access system tokens via the dcdbas > > kernel module and a SMI call that will cause the platform to execute > > SMM code. > > > > With a goal in mind of deprecating the dcdbas kernel module a different > > method for accessing these tokens from userspace needs to be created. > > > > This is intentionally marked to only be readable as root as it can > > contain sensitive information about the platform's configuration. > > > > MAINTAINERS was missing for this driver. Add myself and Pali to > > maintainers list for it. > > > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx> > > > Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > To be clear I just suggested the output format in ->show() callback. Andy, do you mean you would prefer not to be attributed in the description, or should I be clearer that was your suggestion?
