Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 4, 2017 at 4:00 AM, sathyanarayanan kuppuswamy
<sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
> On 10/01/2017 07:44 AM, Andy Shevchenko wrote:
>> On Tue, Sep 5, 2017 at 8:37 AM,

>>> +       punit_cell.id = -1;
>
> I will remove this line in next version.
>>>
>>> +       return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO,
>>> +                       &punit_cell, 1, NULL, 0, NULL);
>>
>> IIRC you don't need to file cell ID in case of DEVID_AUTO.
>
> I am planning to use DEVID_NONE here to match the current behavior. Unless
> you have some concerns?

Preventing behaviour is a good thing to do.
In either way cell.id can be leaved 0.

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux