On Wed, Sep 27, 2017 at 11:02:18PM -0500, Mario Limonciello wrote: > Currently userspace tools can access system tokens via the dcdbas > kernel module and a SMI call that will cause the platform to execute > SMM code. > > With a goal in mind of deprecating the dcdbas kernel module a different > method for accessing these tokens from userspace needs to be created. > > This is intentionally marked to only be readable as root as it can > contain sensitive information about the platform's configuration. > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx> > --- ... > +static ssize_t tokens_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + size_t off = 0; > + int i; > + > + for (i = 0; i < da_num_tokens; i++) { > + if (off > PAGE_SIZE) > + break; > + off += scnprintf(buf+off, PAGE_SIZE-off, "%04x\t%04x\t%04x\n", Minor Coding Style nit - spaces around binary operators: 3.1) Spaces -- Darren Hart VMware Open Source Technology Center