> -----Original Message----- > From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx] > Sent: Wednesday, September 27, 2017 1:22 PM > To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx> > Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>; LKML <linux- > kernel@xxxxxxxxxxxxxxx>; platform-driver-x86@xxxxxxxxxxxxxxx; > quasisec@xxxxxxxxxx; pali.rohar@xxxxxxxxx > Subject: Re: [PATCH v2 03/14] platform/x86: dell-wmi: Don't match on descriptor > GUID modalias > > On Tue, Sep 26, 2017 at 01:50:01PM -0500, Mario Limonciello wrote: > > The descriptor GUID is not used to indicate that WMI notifications > > in the dell-wmi driver work properly. As such a modalias should > > not be present that causes this driver to load on systems with this > > GUID. > > > > Reviewed-by: Pali Pohar <pali.rohar@xxxxxxxxx> > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx> > > I can do this manually, but for future reference: > > Nit, in general, the author's sign off should be first, followed by > reviewers and testers. The maintainer will add their sign off at the end > - this keeps things clear regarding the development and delivery path. > In general, assume chronological order and you'll have the right idea. > > Informational tags, like Reported, Suggested, Tested, and Fixes can come > before the Author sign off, which is consistent with the chronological > order. > Operationally is there is a flag I'm missing in git-format-patch that does this? git format-patch -s puts my sign off at the very bottom, so this is a manual action to re-order if I'm adding in Reviewed-by: in the patch description.
