Re: [PATCH] platform/x86: fujitsu-laptop: Don't oops when FUJ02E3 is not presnt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > I need to refresh my memory a bit and think about next steps.  I still
> > have one more cleanup series queued that is worth posting and I also
> > need to fix radio LED detection.  My spare time is still very limited,
> > but I will do my best to post something soon.
> 
> In the meantime, I think we ought to consider pushing the proposed patch in
> order to restore functionality for the S6120 - as it stands the code oopses,
> which isn't great.  Is there any reason not to do so?

It might only be worth considering to check whether device is NULL
inside call_fext_func() in order to prevent any further issues like this
in the future.  However, for now bl_update_status() is the only place in
fujitsu-laptop using the fext module-wide variable, so the patch is okay
as it is, too.

-- 
Best regards,
Michał Kępień



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux