On Tue, 05 Sep 2017, Vadim Pasternak wrote: > > -----Original Message----- > > From: Lee Jones [mailto:lee.jones@xxxxxxxxxx] > > Sent: Tuesday, September 05, 2017 10:36 AM > > To: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > > Cc: robh+dt@xxxxxxxxxx; pavel@xxxxxx; devicetree@xxxxxxxxxxxxxxx; > > j.anaszewski@xxxxxxxxxxx; rpurdie@xxxxxxxxx; linux-leds@xxxxxxxxxxxxxxx; > > jiri@xxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; platform-driver- > > x86@xxxxxxxxxxxxxxx > > Subject: Re: [patch v4 2/2] mfd: Add Mellanox regmap I2C driver This should not appear in your replies. Please fix your mailer. > > On Tue, 29 Aug 2017, Vadim Pasternak wrote: > > > > > This patch adds I2C regmap driver for Mellanox BMC cards with the > > > programmable devices attached to I2C interface. It allows support for > > > CPLD devices with one and two bytes address space. > > > > > > Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > > > Acked-by: Pavel Machek <pavel@xxxxxx> > > > --- > > > MAINTAINERS | 1 + > > > drivers/mfd/Kconfig | 13 ++++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/mlxreg-i2c.c | 183 > > > +++++++++++++++++++++++++++++++++++++++++++++++ > > > 4 files changed, 198 insertions(+) > > > create mode 100644 drivers/mfd/mlxreg-i2c.c > > > > I don't know what this is, but it is not an MFD driver. Please find somewhere > > more appropriate to locate it. MFD is not a dumping ground for drivers > > which do not fit anywhere else. > > Hi Lee, > > As according your previous notes I am splitting hotplug driver and moving it to new > folder drivers/platform/mellanox/, possibly it would be the best place to relocate it > there. I also intend to have in the future small drivers mlxreg-spi, mlxreg-mmio and > maybe it would be correct to to use these new folder for all of them? I'm afraid I don't have the topology of the driver in my mind. I guess those decisions will be best taken by the Platform maintainer. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
