On Thu, 24 Aug 2017 11:23:18 +0200, Andy Shevchenko wrote: > > On Thu, Aug 24, 2017 at 11:11 AM, Takashi Iwai <tiwai@xxxxxxx> wrote: > > This patch adds the opregion driver for Dollar Cove TI PMIC on Intel > > Cherry Trail devices. The patch is based on the original work by > > Intel, found at: > > https://github.com/01org/ProductionKernelQuilts > > with many cleanups and rewrites. > > > > The driver is currently provided only as built-in to follow other > > PMIC opregion drivers convention. > > > > The re-enumeration of devices at probe is required for fixing the > > issues on HP x2 210 G2. See bug#195689. > > > > One comment below, otherwise (snip) > > +static int dc_ti_pmic_get_raw_temp(struct regmap *regmap, int reg) > > +{ > > + u8 buf[2]; > > + unsigned int val; > > + > > + if (regmap_bulk_read(regmap, reg, buf, 2)) > > + return -EIO; > > + > > + /* stored in big-endian */ > > > + val = buf[0] & 0x03; > > + return (val << 8) | buf[1]; > > Do you need a temporary variable at all? > > return ((buf[0] & 0x03) << 8) | buf[1]; Right it can be dropped. Will address it in the next round. thanks, Takashi
