On Thu, 24 Aug 2017 11:27:32 +0200, Andy Shevchenko wrote: > > On Thu, Aug 24, 2017 at 11:11 AM, Takashi Iwai <tiwai@xxxxxxx> wrote: > > Hi, > > > > this is the revised patch set to add the support for Dollar Cove TI > > PMIC found on some Intel Cherry Trail laptops / tablets. All drivers > > are based on the original code from Intel downstream patches, with > > lots of rewrites and cleanups. MFD driver is implemented as a > > stand-alone like a few other variants, and the input driver got a diet > > in a minimalistic form. > > > > The patch set has been tested on ASUS E100H and E200H, as well as on > > HP x210. > > > > v1->v2: > > - Minor cleanups in mfd driver code as suggested by Andy > > - Move power-button driver to platform/x86, driver renames accordingly > > - Add missing wake-irq cleanup to power-button driver > > - get_raw_temp cleanup in opregion driver, mention about register > > endianess > > > > > > Global comment to the series, we agreed with Hans to follow the > pattern for Intel PMIC driver (module / file) names: > > intel_XXX_<PLATFORM><PMIC>, where <PLATFORM> is 3 letter encoded Intel > platform name, like cht for CherryTrail and <PMIC> is two letter > abbreviation from ZZZ Cove, like wc for Whiskey Cove. > > Here I understand that there is a potential of two PMIC variants for > the same platform DC from Intel, DC from TI. I dunno if former will be > a case in the future, though we may use something like > > intel_XXX_chtdc_ti > > for the latter one. Noted. Also I forgot again to add Hans to Cc. Will put him in the next round. thanks, Takashi