Make these const. Done using Coccinelle. @match disable optional_qualifier@ identifier s; @@ static struct device_attribute s = {...}; @ref@ position p; identifier match.s; @@ s@p @good1@ identifier match.s; expression e1; position ref.p; @@ device_remove_file(e1,&s@p,...) @good2@ identifier match.s; expression e1; position ref.p; @@ device_create_file(e1,&s@p,...) @bad depends on !good1 && !good2@ position ref.p; identifier match.s; @@ s@p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct device_attribute s; Bhumika Goyal (6): ACPI: make device_attribute const nbd: make device_attribute const hid: make device_attribute const qlogic: make device_attribute const platform/x86: make device_attribute const power: supply: make device_attribute const drivers/acpi/battery.c | 2 +- drivers/acpi/sbs.c | 2 +- drivers/block/nbd.c | 2 +- drivers/hid/hid-core.c | 2 +- drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 4 ++-- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 6 +++--- drivers/platform/x86/classmate-laptop.c | 6 +++--- drivers/platform/x86/intel-rst.c | 4 ++-- drivers/power/supply/olpc_battery.c | 2 +- 9 files changed, 15 insertions(+), 15 deletions(-) -- 1.9.1