On Wed, Aug 16, 2017 at 1:42 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> On Mon, Aug 14, 2017 at 06:32:48PM +0300, Andy Shevchenko wrote:
>> On Mon, Aug 14, 2017 at 5:17 PM, Hao Wei Tee <angelsl@xxxxxxx> wrote:
>> > +static int method_gbmd(acpi_handle handle, unsigned long *ret)
>> > +{
>> > + int val;
>> > + int result = read_method_int(handle, "GBMD", &val);
>>
>> Reversed X-mas tree order in new code, please.
>
> Generally yes, but of here they are using &val in the second initializer.
>
> So either as is or:
>
> int result;
> int val;
>
> result = read_method_int(handle, "GBMD", &val)
>
> I tend to accept it as is when there is a declaration order dependency like
> this.
There is a new version which I applied, there is no dependencies left.
--
With Best Regards,
Andy Shevchenko
