On Sun, Aug 13, 2017 at 03:54:26PM +0300, Andy Shevchenko wrote: > On Sat, Aug 12, 2017 at 10:44 AM, Pali Rohár <pali.rohar@xxxxxxxxx> wrote: > > This patch series fixes remaining mxm-wmi and asus-wmi drivers to evaluate > > WMI methods with correct and available instance number. Now all WMI drivers > > should call WMI functions with correct instance number and last patch fixes > > WMI check for invalid instances. Patch for paeq-wmi is optional as machine > > has 10 instances but instance number is ignored at all. But for consistency > > with other drivers first instance would be used (instead of second). > > > > I pushed first 3 to testing, which seems to me right thing to do, and > left the last one to be ACK by Darren and/or others (I'm not familiar > so far with that code). Reviewed with one question to Pali. Since you merged 1-3, I'll leave 4 to you unless you prefer I merge it. > Thanks! > > > Pali Rohár (4): > > platform/x86: mxm-wmi: Evaluate wmi method with instance number 0x0 > > platform/x86: asus-wmi: Evaluate wmi method with instance number 0x0 > > platform/x86: peaq-wmi: Evaluate wmi method with instance number 0x0 > > platform/x86: wmi: Fix check for method instance number > > > > drivers/platform/x86/asus-wmi.c | 4 ++-- > > drivers/platform/x86/mxm-wmi.c | 4 ++-- > > drivers/platform/x86/peaq-wmi.c | 2 +- > > drivers/platform/x86/wmi.c | 6 +++--- > > 4 files changed, 8 insertions(+), 8 deletions(-) > > > > -- > > 1.7.9.5 > > > > > > -- > With Best Regards, > Andy Shevchenko > -- Darren Hart VMware Open Source Technology Center
