On Tue, Aug 01, 2017 at 08:37:26AM -0700, Andy Lutomirski wrote: > When I converted dell-wmi to the new bus infrastructure, I left the > call to dell_wmi_check_descriptor_buffer() in dell_wmi_init(). This > could cause two problems: > > - An error message when loading the driver on a system without > dell-wmi. We'd try to read the event descriptor even if the WMI > GUID wasn't there. > > - A possible race if dell-wmi was loaded manually before wmi was > fully initialized. > > Fix it by moving the call to the probe function where it belongs. > > Fixes: bff589be59c5 ("platform/x86: dell-wmi: Convert to the WMI bus infrastructure") > Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx> Queueing this one (1/3) to testing. Pali, aside from the separate input event receiving discussion, do you have any concerns with this patch? I'd like to get this to Linus this week for our 4.13-2 PR for this RC cycle. -- Darren Hart VMware Open Source Technology Center