On Sat, Jul 22, 2017 at 2:16 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote: > On Thu, Jul 20, 2017 at 08:56:48PM -0700, Alex Hung wrote: >> Unsupported events is only useful for developers and does not meaningful >> for users. Using dev_dbg makes more sense and reduces noise in kernel >> messages. >> - dev_info(&device->dev, "unknown event index 0x%x\n", event); >> + dev_dbg(&device->dev, "unknown event index 0x%x\n", event); > > info is the most common log level for these events in the platform > driver x86 subsystem per 'git grep -i "unknown event"'. > > My take on this is that we want these to be reported by users, rather > than rely on developers to find them all - especially as the developers > only see a fraction of the affected hardware. > > Are you finding these to be causing a problem / or producing really > excessive log messages? > > Andy, what are your thoughts? My opinion is slightly closer to Rafael's one. I think this is a debugging context. If we really care about reporting them we might go HID way, i.e. using dev_printk(KERN_DEBUG ) with module parameter debug. As developer I'm against that. As a regular user I do not need to recompile a kernel, in case there is no dynamic debug support, and it allows me to enable debug messages. P.S. To see how important message above is, do we have any statistics how many bug reports / email we got wrt the issue and how many had been addressed? -- With Best Regards, Andy Shevchenko
