Just missed the email from Darren. Reviewed-by: Souvik K Chakravarty <souvik.k.chakravarty@xxxxxxxxx> > -----Original Message----- > From: Chakravarty, Souvik K > Sent: Friday, July 21, 2017 8:45 AM > To: 'Rajneesh Bhardwaj' <rajneesh.bhardwaj@xxxxxxxxx>; platform-driver- > x86@xxxxxxxxxxxxxxx > Cc: dvhart@xxxxxxxxxxxxx; andy@xxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Murthy, Shanth <shanth.murthy@xxxxxxxxx>; > Bhardwaj, Rajneesh <rajneesh.bhardwaj@xxxxxxxxx> > Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition > > Both set of two looks good. +1. > > > -----Original Message----- > > From: platform-driver-x86-owner@xxxxxxxxxxxxxxx > > [mailto:platform-driver- x86-owner@xxxxxxxxxxxxxxx] On Behalf Of > > Rajneesh Bhardwaj > > Sent: Thursday, July 20, 2017 7:51 PM > > To: platform-driver-x86@xxxxxxxxxxxxxxx > > Cc: dvhart@xxxxxxxxxxxxx; andy@xxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; Murthy, Shanth <shanth.murthy@xxxxxxxxx>; > > Chakravarty, Souvik K <souvik.k.chakravarty@xxxxxxxxx>; Bhardwaj, > > Rajneesh <rajneesh.bhardwaj@xxxxxxxxx> > > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition > > > > Telemetry driver includes intel_telemetry.h which defines > > TELEM_MAX_OS_ALLOCATED_EVENTS already. > > > > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxx> > > --- > > drivers/platform/x86/intel_telemetry_pltdrv.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c > > b/drivers/platform/x86/intel_telemetry_pltdrv.c > > index 6393b3b1d5a6..e0424d5a795a 100644 > > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c > > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c > > @@ -46,7 +46,6 @@ > > #define TELEM_SAMPLING_DEFAULT_PERIOD 0xD > > > > #define TELEM_MAX_EVENTS_SRAM 28 > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS 20 > > #define TELEM_SSRAM_STARTTIME_OFFSET 8 > > #define TELEM_SSRAM_EVTLOG_OFFSET 16 > > > > -- > > 2.7.4
