Re: [PATCH v2 1/1] intel_telemetry_debugfs: fix oops found while load/unload module test

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Jun 2, 2017 at 12:33 AM,  <priyalee.kushwaha@xxxxxxxxx> wrote:
> This fix oops found while testing load/unload test of
> intel_telemetry_debugfs module. Module_init uses register_pm_notifier
> for PM callbacks, but unregister_pm_notifier was missing from
> module_exit.

> +#ifdef CONFIG_PM_SLEEP
> +       unregister_pm_notifier(&pm_notifier);
> +#endif /* CONFIG_PM_SLEEP */

Neither here

> +#ifdef CONFIG_PM_SLEEP
> +       unregister_pm_notifier(&pm_notifier);
> +#endif /* CONFIG_PM_SLEEP */

Not there.

AFAIU we discussed to make unregister_pm_notifier() having stubs for !PM_SLEEP.

-- 
With Best Regards,
Andy Shevchenko