On Saturday 27 May 2017 07:15:28 Darren Hart wrote: > From: Andy Lutomirski <luto@xxxxxxxxxx> > > The hotkey table is 0xb2, add a comment for clarity. > > Suggested-by: Darren Hart <dvhart@xxxxxxxxxxxxx> > Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx> > Cc: Matthew Garrett <mjg59@xxxxxxxxxxxxx> > Cc: "Pali Rohár" <pali.rohar@xxxxxxxxx> > Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx> > Signed-off-by: Darren Hart (VMware) <dvhart@xxxxxxxxxxxxx> > --- > drivers/platform/x86/dell-wmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/dell-wmi.c > b/drivers/platform/x86/dell-wmi.c index 8a64c79..24467b1 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -449,6 +449,7 @@ static void __init handle_dmi_entry(const struct > dmi_header *dm, if (results->err || results->keymap) > return; /* We already found the hotkey table. */ > > + /* The Dell hotkey table is type 0xB2. Scan until we find it. */ > if (dm->type != 0xb2) > return; Good. Reviewed-by: Pali Rohár <pali.rohar@xxxxxxxxx> (Maybe in future we should add a #define name for such magic constants) -- Pali Rohár pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part.