On Tue, 23 May 2017 13:55:39 -0700 Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > The function was added by commit 0a8b83530b6f ("intel_pmc_ipc: Add Intel > Apollo Lake PMC IPC driver") in 2015 and hasn't been used since then. > Removing it fixes the following warning when building with clang: > > drivers/platform/x86/intel_pmc_ipc.c:189:18: error: unused function > 'ipc_data_readb' [-Werror,-Wunused-function] It is however also part of the API and a consistent sensible function to have present should it be needed. As it's static it's eliminated correctly by gcc. I'm all for eliminating unused functions but in this case I have to wonder Alan