On Tue, May 09, 2017 at 08:42:21AM +0200, Hans de Goede wrote: > On 08-05-17 23:04, Darren Hart wrote: > > On Mon, May 08, 2017 at 09:56:31PM +0200, Hans de Goede wrote: > > > + peaq_poll_dev->input->name = "PEAQ WMI hotkeys"; > > > > Are there additional keys/buttons? > > Not through the WMI interface on this model, I decided on the > "PEAQ WMI hotkeys" name rather then say "PEAQ Dolby button" > as future proofing (this gets exported to userspace so > we should not change it in the future) in case this driver > ends up delivering events for more special buttons on > PEAQ devices. > > As for all the other remarks from both you and Dmitry I agree > with all of them and I will send a v2 addressing them all. > Sounds good, thanks Hans. -- Darren Hart VMware Open Source Technology Center
