On Mon, Apr 24, 2017 at 11:47 PM, Maarten Maathuis <madman2003@xxxxxxxxx> wrote: > Tested on HP Elite X2 1012 G1. > Matches event report of Lenovo Helix 2 > (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html). Thanks for the patch. A bit of work still required. According to Submitting Patches document [1] we need your Signed-off-by tag. Besides that see my comment below. [1] https://www.kernel.org/doc/Documentation/process/submitting-patches.rst > --- > drivers/platform/x86/intel-vbtn.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c > index 554e82ebe83c..1fbebbad350d 100644 > --- a/drivers/platform/x86/intel-vbtn.c > +++ b/drivers/platform/x86/intel-vbtn.c > @@ -35,8 +35,12 @@ static const struct acpi_device_id intel_vbtn_ids[] = { > > /* In theory, these are HID usages. */ > static const struct key_entry intel_vbtn_keymap[] = { > - { KE_IGNORE, 0xC0, { KEY_POWER } }, /* power key press */ > - { KE_KEY, 0xC1, { KEY_POWER } }, /* power key release */ > + { KE_IGNORE, 0xC0, { KEY_POWER } }, /* power key press */ > + { KE_KEY, 0xC1, { KEY_POWER } }, /* power key release */ As far as I can see nothing should happen on these lines. I think your editor (or maybe email setup) is configured somehow wrongly. We expect TAB as an indentation starter. We also encourage to use git send-email tool instead of manual submitting patches through some (broken) MUAs. > + { KE_KEY, 0xC4, { KEY_VOLUMEUP} }, /* volume-up key press */ > + { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key release */ > + { KE_KEY, 0xC6, { KEY_VOLUMEDOWN} }, /* volume-down key press */ > + { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */ > { KE_END }, -- With Best Regards, Andy Shevchenko
