On Sat, Apr 22, 2017 at 5:19 AM, Jérémy Lefaure
<jeremy.lefaure@xxxxxxxxxxxx> wrote:
> The cpufv sysfs file is defined as readable by anyone even if the
> attribute does not have a show function. The result of every read is an
> IO error. This file should be write only.
Per se patch looks good to me, though would be better to add show()
hook as well?
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@xxxxxxxxxxxx>
> ---
> drivers/platform/x86/asus-wmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 8499d3ae4257..0ace471cb700 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -1761,7 +1761,7 @@ ASUS_WMI_CREATE_DEVICE_ATTR(cardr, 0644, ASUS_WMI_DEVID_CARDREADER);
> ASUS_WMI_CREATE_DEVICE_ATTR(lid_resume, 0644, ASUS_WMI_DEVID_LID_RESUME);
> ASUS_WMI_CREATE_DEVICE_ATTR(als_enable, 0644, ASUS_WMI_DEVID_ALS_ENABLE);
>
> -static ssize_t store_cpufv(struct device *dev, struct device_attribute *attr,
> +static ssize_t cpufv_store(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count)
> {
> int value, rv;
> @@ -1778,7 +1778,7 @@ static ssize_t store_cpufv(struct device *dev, struct device_attribute *attr,
> return count;
> }
>
> -static DEVICE_ATTR(cpufv, S_IRUGO | S_IWUSR, NULL, store_cpufv);
> +static DEVICE_ATTR_WO(cpufv);
>
> static struct attribute *platform_attributes[] = {
> &dev_attr_cpufv.attr,
> --
> 2.12.2
>
--
With Best Regards,
Andy Shevchenko
