Re: [PATCH] platform/x86: asus-wmi: try to set als by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 21.04.2017 um 21:06 schrieb Andy Shevchenko:
> On Fri, Apr 21, 2017 at 6:24 PM, Oleksij Rempel <linux@xxxxxxxxxxxxxxxx> wrote:
>> some laptops, for example ASUS UX330UAK, have brocken als_get function
>> but working als_set funktion. In this case, ALS will stay turned off.
> 
> Please, spell check the above.
> 
> some -> Some
> brocken -> broken
> funktion -> function
> 
>>
>>              Method (WMNB, 3, Serialized)
>>             {
>>             ...
>>                If (Local0 == 0x53545344)
>>                 {
>>                 ...
>>                     If (IIA0 == 0x00050001)
>>                     {
>>                         If (!ALSP)
>>                         {
>>                             Return (0x02)
>>                         }
>>
>>                         Local0 = (GALS & 0x10)    <<<---- bug,
>>                                                     should be: (GALS () & 0x10)
> 
> How GALS is defined in ASL?
> 
>> Since it works without problems on Windows I assume ASUS WMI driver for Win
>> never trying to get ALS state, and instead it is setting it by default to ON.
>>
>> This patch will do the same. Turn ALS on by default.
> 
> It would be good to see if there is no regression added.

I just send this email to ASUS support, may be some thing will happen:
https://pastebin.com/TLjbbNMc

-- 
Regards,
Oleksij

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux