On Thu, Apr 20, 2017 at 10:38:56AM +0300, Andy Shevchenko wrote: > On Thu, Apr 20, 2017 at 5:25 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote: > > From: "Darren Hart (VMware)" <dvhart@xxxxxxxxxxxxx> > > > > This series factors out some redundant code, cleans up a number of style issues, > > modernizes the sysfs usage, and cleans up the return paths. All told, the driver > > is reduced in size by 37 lines (3.6%). > > > > I do not have an HP laptop, so I'm hoping Carlo can help out with some testing. > > In particular we need to verify that hotkeys and sysfs continue to work as > > before. > > > > Series looks good to me except patch 2. So, > > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > with above exception. I was on the fence with this one, which is why I separated it out. I'll drop it. Thanks for the review. -- Darren Hart VMware Open Source Technology Center
