On Wed, Apr 19, 2017 at 10:11 PM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote: > On Wed, Apr 19, 2017 at 07:41:53PM +0200, Carlo Caione wrote: >> From: Carlo Caione <carlo@xxxxxxxxxxxx> >> >> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state, >> ...) using hp_wmi_perform_query to perform an HP WMI query shadow the >> returned value in case of error. >> >> We return -EINVAL only when the HP WMI query returns a positive value >> (the specific error code) to not mix this up with the actual value >> returned by the helper function. > > So Andy is correct in that we try to avoid shadowing error codes where possible. > I accepted v1 of this series because it fixed an existing problem in a way > consistent with the existing code. > > Since v1 is already in for-next, let's consider the following a subsequent > cleanup. Would you please create a new patch to address the shadowing error code > issues on top of the v1 patch series. No problem. On its way. -- Carlo Caione | +39.340.80.30.096 | Endless
