Hi Andy,
On 04/04/2017 06:23 AM, Andy Shevchenko wrote:
On Mon, Apr 3, 2017 at 4:51 AM, Sathyanarayanan Kuppuswamy Natarajan
<sathyaosid@xxxxxxxxx> wrote:
+static inline int is_gcr_valid(u32 offset)
Pointer to ipcdev should be a parameter to this function.
But ipcdev is a static variable, visible across this file. So there is
no point in passing it as parameter.
That's one of refactoring needed for this library. You need to pass a
pointer to all internal functions and where it's possible to avoid
reference to a global variable.
Yes, I have included this into the list of issues that needs to fixed
during the refactoring effort.
--
Sathyanarayanan Kuppuswamy
Android kernel developer
