On Tue, Apr 04, 2017 at 11:39:03AM +0200, Michał Kępień wrote: > acpi_execute_simple_method() takes a method parameter which tells it to > look for the given method underneath the given handle, so calling > acpi_get_handle() beforehand is redundant. Replace the call to > acpi_get_handle() with a call to acpi_execute_simple_method(), thus > eliminating the need for a local variable storing the handle. Update > debug message to reflect this change. Also do not assign a default > value to status as it has no influence on execution flow. > > Signed-off-by: Michał Kępień <kernel@xxxxxxxxxx> > --- > Darren, > > This is patch 04/11 with updated debug and commit messages. Now that > you mentioned this issue, I think we should do the same for patch 2/3 in > the call_fext_func() cleanup series [1]. Would you like me to just send > an updated version of that specific patch (similarly to what I did in > this case) or rather send v2 of the entire call_fext_func() cleanup > series? Thanks, looks good. Now that there is more than one cleanup, please do just send a v2 of the entire series. Less error prone that way. Thanks, -- Darren Hart VMware Open Source Technology Center
