On Thu, Mar 16, 2017 at 11:55:35AM +0100, Hans de Goede wrote: > Make dell-wmi notify on hotkey kbd brightness changes, listen for this > in dell-laptop and call led_classdev_notify_brightness_hw_changed. > > This will allow userspace to monitor (poll) for brightness changes on > these LEDs caused by the hotkey. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> Thanks Hans, this appears to be consistent with the conclusion on v8 between you and Pali. While I don't care for the cross-driver-dependency, that's pre-existing and not something I have a solution for. So this looks good to me, pending Pali's final review. Pali, I know you have had some reservations reading through the v8 discussion. I believe Hans has addressed each of those sufficiently for the purposes of this patch set. As a follow-on effort, I'd like to discuss the future of libsmbios with the Dell folks and see if we can't phase it out. Hans, a couple of nits on this patch. To keep the subject under 80, I used: platform/x86: dell-*: Call new led hw_changed API on kbd brightness change since you used the full led function name in the commit message anyway. I presume the changelog was intended to go after the --- and you didn't want it going into the commit itself, so I've removed it. I'll await Pali's final Reviewed-by before pushing to testing, but you can see my minor tweaks listed above in the dell branch: git://git.infradead.org/linux-platform-drivers-x86.git dell http://git.infradead.org/linux-platform-drivers-x86.git/log/refs/heads/dell Thanks, -- Darren Hart VMware Open Source Technology Center
