HI,
On 02-03-17 15:22, Pali Rohár wrote:
On Thursday 02 March 2017 15:12:52 Hans de Goede wrote:
Hi,
On 02-03-17 00:10, Andy Shevchenko wrote:
On Thu, Feb 9, 2017 at 5:44 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
Here is v8 of the platform drivers changes matching / using the new
v8 LED subsys led_classdev_notify_brightness_hw_changed() functionality
queued in -next.
There have been some changes (and preparation patches added) compared
to the previous versions since the new LED api requires the driver to
only call led_classdev_notify_brightness_hw_changed() on hotkey triggered
changes and the ACPI events indicating brightness changes also get
triggered when setting the brightness to led_set_brightness (or sysfs).
This series depends on the patch adding
led_classdev_notify_brightness_hw_changed() to the LED subsystem,
Jacek can you create a stable branch with just that patch which the
platform/x86 platform maintainers can merge, so that they can apply
this series ?
I briefly read the discussion and looks like I'll wait for v9 after
merge window is closed.
Ok.
Note the 3 acpi-thinkpad patches have been in
linux-platform-drivers-x86.git/testing for a while now and there has been
no discussion surrounding those. Do you want me to send a v9 of those too,
or just the Dell driver patches ?
If we all agree on change for Dell driver to just drop one event, maybe
we can discuss if similar approach should be used also for Thinkpad
driver...
As mentioned during the review of the thinkpad patches already, there is no
guarantee that all generation thinkpads actually generate events when setting
the brightness through calling into the BIOS, so doing this may cause actual
hotkey events to get swallowed. So lets just keep this as is.
Note I still need to test that a similar problem does not exist for the Dell
case.
Regards,
Hans
