On 18 February 2017 at 15:30, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> Hello João Paulo Rechi Vita,
>
> The patch 2c1a49c96123: "asus-wireless: Toggle airplane mode LED"
> from Jun 13, 2016, leads to the following static checker warning:
>
> drivers/platform/x86/asus-wireless.c:54 asus_wireless_method()
> error: uninitialized symbol 'ret'.
>
> drivers/platform/x86/asus-wireless.c
> 33 static u64 asus_wireless_method(acpi_handle handle, const char *method,
> 34 int param)
> 35 {
> 36 struct acpi_object_list p;
> 37 union acpi_object obj;
> 38 acpi_status s;
> 39 u64 ret;
> 40
> 41 acpi_handle_debug(handle, "Evaluating method %s, parameter %#x\n",
> 42 method, param);
> 43 obj.type = ACPI_TYPE_INTEGER;
> 44 obj.integer.value = param;
> 45 p.count = 1;
> 46 p.pointer = &obj;
> 47
> 48 s = acpi_evaluate_integer(handle, (acpi_string) method, &p, &ret);
>
> "ret" isn't necessarily initialized on a couple error paths through this
> function.
>
Yes, I have missed that, thanks for catching it! I'll send a fix to this.
--
João Paulo Rechi Vita
http://about.me/jprvita
