> > Thanks Alex, I've queued this to testing and it will go to for-next unless the
> > CI, Pali, or a user reports a problem. Appreciate all your effort on this one.
>
> Thanks for the review. I will send another patch to address all comments later.
Alex, I have only just now noticed one more really trivial issue: a
space is missing in each keymap entry before the first right curly
bracket:
> +/* 5 button array notification value. */
> +static const struct key_entry intel_array_keymap[] = {
> + { KE_KEY, 0xC2, { KEY_LEFTMETA} }, /* Press */
{ KE_KEY, 0xC2, { KEY_LEFTMETA } },
^
etc.
> + { KE_IGNORE, 0xC3, { KEY_LEFTMETA} }, /* Release */
> + { KE_KEY, 0xC4, { KEY_VOLUMEUP} }, /* Press */
> + { KE_IGNORE, 0xC5, { KEY_VOLUMEUP} }, /* Release */
> + { KE_KEY, 0xC6, { KEY_VOLUMEDOWN} }, /* Press */
> + { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN} }, /* Release */
> + { KE_SW, 0xC8, { .sw = {SW_ROTATE_LOCK, 1} } }, /* Press */
> + { KE_SW, 0xC9, { .sw = {SW_ROTATE_LOCK, 0} } }, /* Release */
For these two lines, I would personally insert a space next to each of
the innermost curly brackets, like this:
{ KE_SW, 0xC9, { .sw = { SW_ROTATE_LOCK, 0 } } },
> + { KE_KEY, 0xCE, { KEY_POWER} }, /* Press */
> + { KE_IGNORE, 0xCF, { KEY_POWER} }, /* Release */
> + { KE_END },
> +};
To avoid churn, perhaps the maintainers could do this for you while
moving this patch to for-next? Or we can simply ignore this, as I said
this is just a minor annoyance.
--
Best regards,
Michał Kępień
