Re: [PATCH] Add sysfs interface for touchpad state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Wed, 2017-02-01 at 17:07 +0200, Andy Shevchenko wrote:
> > root@learner:/sys/class/input# od -x /dev/input/event6
> > ?0000000 ee33 5891 0000 0000 2bd9 0005 0000 0000
> > ^@0000020 0004 0004 0042 0000 ee33 5891 0000 0000
> > 0000040 2bd9 0005 0000 0000 0001 00c1 0001 0000
> > 0000060 ee33 5891 0000 0000 2bd9 0005 0000 0000
> > 0000100 0000 0000 0000 0000 ee33 5891 0000 0000
> > 0000120 2c09 0005 0000 0000 0001 00c1 0000 0000
> > 0000140 ee33 5891 0000 0000 2c09 0005 0000 0000
> > 0000160 0000 0000 0000 0000 ee37 5891 0000 0000
> > 0000200 3d7e 000f 0000 0000 0004 0004 0043 0000
> > 0000220 ee37 5891 0000 0000 3d7e 000f 0000 0000
> > 0000240 0001 00c0 0001 0000 ee37 5891 0000 0000
> > 0000260 3d7e 000f 0000 0000 0000 0000 0000 0000
> > 0000300 ee37 5891 0000 0000 3dae 000f 0000 0000
> > 0000320 0001 00c0 0000 0000 ee37 5891 0000 0000
> > 0000340 3dae 000f 0000 0000 0000 0000 0000 0000
> 
> So, the whole idea of this exercise is to show that driver sends an
> event whenever you bend / unbend the cover.
> User space already will know what is the state of the cover.
> 

Yes. But we've not found the interface in sysfs where we could read that from.
Nor did udev report anything meaningful for it.

> > By the way, does the patch make sense for
> > inclusion ? To have an interface for touchpad mode ?
> 
> The question now is why do you need that on top of existing event?

If you have time, please see:
https://bugs.launchpad.net/bugs/1366421

It has pretty much all the details on what and why we need something in sysfs.

For HP and ThinkPad, there already are interfaces available.

/sys/devices/platform/hp-wmi/tablet
/sys/devices/platform/thinkpad_acpi/hotkey_tablet_mode

It'd be nice to see the same for Yoga IdeaPad; a proper interface for tablet-
mode.

- -- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQCVDstmIVAB/Yn02pjpYo/LhdWkFAliSChYACgkQpjpYo/Lh
dWm/LhAAitvcaPzR2fUR6gtlxMLOQDTEPA8rjQdVmIBFLYPV9OTyJPkjz9V0aZlR
S4BcGa43foXLNsj5tGFNoy8gucwQ2bpEEpPJazlsmRVk9SB7Ui0GVzU673EUqCHD
wR3NI4MzlEmo6RV8DxTyx6rGOjGH2XGjwi6cbfZFLiehw7RjYZV5ggO5uxK+O43n
EbudMaiHOZeg+rYtU+c162TdAjPwwWTiTx5LJvZpam7QS3M31U76PdVt75bacbfH
m7TarxK15ksP9Mmj3DJnXKavOS5u92mPRkSIZmE/hmWsJ/X6tmTzgX0tHddF4N+7
yaftBwglqV6Da8Xylc9GKkC2Q/b0mXSQqTwr86fK2TyKY6HHj5QJ6CNG9gwP33tG
Kg2zIpMzKul7FHpJeQIrHL312Z/4bek1Islki2ydt8CwdheMPTnxUqcFNKpaTItM
FudQTJuaffXinmavGtwco/iFBqJbnqX3RkgWpXxyIvG4NTLrcMcMDKY6DRo+f2FB
0ojU2APhPZ+63+fvCwO1Bv06/vbzfphkOvgQv6w2laekmuCJaF2RfQDj8N+DiteH
LRmqYpF4UEr4WnJeHuumV3oRQsjHU6exdzg/5oBNyJ1vD8CzRFYvTgyNmdunmFnp
ybuVmjVIjFKxGnF1x46ZFF+o7CM0+3XeC6vFYbT3WNDQq1iQKTY=
=/CI9
-----END PGP SIGNATURE-----




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux