On Wed, Jan 11, 2017 at 09:59:32AM +0100, Micha?? K??pie?? wrote:
> The loop condition in acpi_fujitsu_hotkey_release() includes an
> assignment, a four-argument function call and a comparison, making it
> hard to read. Separate the assignment from the comparison to improve
> readability.
>
> Signed-off-by: Micha?? K??pie?? <kernel@xxxxxxxxxx>
Acked-by: Jonathan Woithe <jwoithe@xxxxxxxxxx>
> ---
> drivers/platform/x86/fujitsu-laptop.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index e57d3724d2ce..06653a8594ed 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -1054,11 +1054,13 @@ static void acpi_fujitsu_hotkey_release(void)
> struct input_dev *input = fujitsu_hotkey->input;
> int keycode, status;
>
> - while ((status = kfifo_out_locked(&fujitsu_hotkey->fifo,
> + while (true) {
> + status = kfifo_out_locked(&fujitsu_hotkey->fifo,
> (unsigned char *)&keycode,
> sizeof(keycode),
> - &fujitsu_hotkey->fifo_lock))
> - == sizeof(keycode)) {
> + &fujitsu_hotkey->fifo_lock);
> + if (status != sizeof(keycode))
> + return;
> input_report_key(input, keycode, 0);
> input_sync(input);
> vdbg_printk(FUJLAPTOP_DBG_TRACE,
> --
> 2.11.0
--
