On Tuesday, January 10, 2017 12:41:17 PM CET Darren Hart wrote: > > Thanks Arnd, > > This appears to be the preferred approach from coding-style.rst 20) Conditional > Compilation - we have some cleanup to do in this area I guess. > > Queued to next, thanks. Thanks! No need to do mass-conversions to __maybe_unused though, Kirtika Ruchandani has started working on a way for the suspend/resume functions to automatically get silently discarded when they are unused, without having an #ifdef or __maybe_unused annotation. For new code, using __maybe_unused helps avoid this bug though, and the conversion to the future macros would be easy enough. Arnd -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html