RE: [patch v3 1/1] platform/x86: move module mlx-platform from arch/x86 to drivers/platform/x86

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx]
> Sent: Monday, November 14, 2016 9:17 AM
> To: Vadim Pasternak <vadimp@xxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>; dvhart@xxxxxxxxxxxxx; platform-
> driver-x86@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> jiri@xxxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx
> Subject: Re: [patch v3 1/1] platform/x86: move module mlx-platform from
> arch/x86 to drivers/platform/x86
> 
> On Tue, Nov 8, 2016 at 8:19 AM, Vadim Pasternak <vadimp@xxxxxxxxxxxx>
> wrote:
> > Hi,
> >
> > Could this patch be merged to for-next for 4.10?
> > When it's merged I'd like to submit another small patch on top of it.
> 

Hi Andy,
Thanks for reply.

> First of all, please avoid top posting.

Sorry for that.
I posted on top, because it doesn't come as reply to something (but it seems I should post at bottom in suc case).

> I will process the pdx86 mailing list and queue this week.
> 
> P.S. Are you sure that is the right fix "Remove "select MLX_PLATFORM"
> from Kconfig, since it has unmet direct dependencies (X86 &&
> X86_PLATFORM_DEVICES && X86_64)"?

There were two possibility: to leave "select MLX_PLATFORM" and add " depends on X86_64". Or just remove select.
I decide to remove, having in mind the next considerations:
If MLX_PLATFORM is not selected here - just nobody will activate hotplug driver;
If in the feature on some systems we'll have ACPI support - hotplug still is relevant. 

> 
> >> On Mon, 31 Oct 2016, Vadim Pasternak wrote:
> >>
> >> > Since mlx-platform is not an architectural driver, it is moved out
> >> > of arch/x86/platform to drivers/platform/x86.
> >> > Relevant Makefile and Kconfig are updated.
> >> >
> >> > Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx>
> >>
> >> Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> 
> --
> With Best Regards,
> Andy Shevchenko
��.n��������+%������w��{.n������_���v��z����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux