Hi, On 11-11-16 15:17, Pali Rohár wrote:
On Tuesday 01 November 2016 14:37:47 Hans de Goede wrote:@@ -43,4 +45,13 @@ void dell_smbios_release_buffer(void); void dell_smbios_send_request(int class, int select); struct calling_interface_token *dell_smbios_find_token(int tokenid); + +enum dell_laptop_notifier_actions { + dell_laptop_kbd_backlight_brightness_changed, +};Should not be upper case? Looks like that Documentation/CodingStyle also suggest it: Names of macros defining constants and labels in enums are capitalized.
Ok, I will send a v5 once we agree on how to do the thinkpad bits. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
