Re: [PATCH v2 1/4] leds: core: Add support for poll()ing the sysfs brightness attr for changes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 27-10-16 08:58, Jacek Anaszewski wrote:
Hi,

On 10/26/2016 05:18 PM, Hans de Goede wrote:
Hi,

On 24-10-16 22:43, Jacek Anaszewski wrote:
Hi Hans,

Thanks for the update.
Could you please rebase your patches onto recent linux-leds.git,
for-next branch?

Done, I will send a v3 soon (today or tomorrow).

Also it would be convenient to have sample application for polling
brightness changes in tools/leds.

I'm sorry but I do not have time to create such a sample application.

You must have tested your solution somehow.

Yes, as is made clear by the other patches in this set, I'm using
it with keyboard backlight control led interfaces. Which in userspace
are handled by upower which provides a dbus interface which is used
by gnome-settings-daemon.

Just polish the code a bit,
add a Makefile and that's it. Compare tools/leds/uledmon.c - it doesn't
need to be anything big.

upower uses gio which is really not suitable for this, so I would need
to create something from scratch.

Regards,

Hans



If you're adding a feature that interacts with userspace, then I'd like
to have a sample code that shows how to use it. Just for a reference.

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux