On Sun, Oct 23, 2016 at 10:23:53AM +0200, Jiri Pirko wrote: > Sun, Oct 23, 2016 at 08:14:53AM CEST, vadimp@xxxxxxxxxxxx wrote: > > > > > >> -----Original Message----- > >> From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx] > >> Sent: Friday, October 21, 2016 9:42 PM > >> To: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > >> Cc: davem@xxxxxxxxxxxxx; geert@xxxxxxxxxxxxxx; akpm@linux- > >> foundation.org; kvalo@xxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > >> mchehab@xxxxxxxxxx; linux@xxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > >> platform-driver-x86@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx > >> Subject: Re: [patch v3] drivers/platform/x86: introduce support for Mellanox > >> hotplug driver > >> > >> On Thu, Oct 20, 2016 at 04:28:01PM +0000, vadimp@xxxxxxxxxxxx wrote: > >> > From: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > >> > > >> > Enable system support for the Mellanox Technologies hotplug platform > >> > driver, which provides support for the next Mellanox basic systems: > >> > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410", > >> > "msb7800", "msn2740", "msn2100" and also various number of derivative > >> > systems from the above basic types. > >> > This driver handles hot-plug events for the power suppliers, power > >> > cables and fans for the above systems. > >> > > >> > The Kconfig currently controlling compilation of this code is: > >> > driver/platform/x86:config MLX_CPLD_PLATFORM > >> > tristate "Mellanox platform hotplug driver support" > >> > > >> > Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > >> > --- > >> > v1->v2: > >> > Comments pointed out by Darren: > >> > - remove whitespaces in config; > >> > - remove redundant includes for header files; > >> > - fix comments styling; > >> > - fix register value assignment in mlxcpld_hotplug_attr_show; > >> > - mlxcpld_hotplug_attr_init - use local aliases to reduce line > >> > length; > >> > - Add fields description in the struct mlxcpld_hotplug_device; > >> > v2->v3: > >> > Comments pointed out by Darren: > >> > - Fix structures and enum comments in mlxcpld-hotplug.c according to > >> > Documentation/kernel-documentation.rst guideline; > >> > - Assign and mask aggregation status in mlxcpld_hotplug_work_handler on > >> > the same line. > >> > - Refactor mlxcpld_hotplug_work_handler. Make common helper routine for > >> > each attribute type. > >> > - Produce error message in case signal is not expected. > >> > - Fix header file according to Documentation/kernel-documentation.rst > >> > guideline; > >> > >> > Fix added by Vadim: > >> > Fix re-scheduling flow for possibly missed signals. By mistake it > >> > was coupled with FAN. > >> > >> Thanks Vadim. Merged to for-next for 4.10. > >> > >> Also for 4.10, it would be good to move mlx-platform out of arch/x86/platform > >> to > >> drivers/platform/x86 as it isn't an architectural driver. Would you be able to > >> prepare the patch? > > > >Hi Darren, > > > >Thank you very much for all your reviews. > > > >Sure, I'll prepare the patch. > > > >Should it be submitted in two different patches (remove in git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git; and add in > >git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git)? > >Or in one patch, in git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git? > > One patch, please. It needs to be in one patch, yes. Otherwise you would leave the platform/driver/x86 side missing it's dependencies... it would be a mess. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
