On Wednesday 19 October 2016 15:33:55 Hans de Goede wrote:
> diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
> index d2412ab..7934953 100644
> --- a/drivers/platform/x86/dell-smbios.c
> +++ b/drivers/platform/x86/dell-smbios.c
> @@ -21,6 +21,7 @@
> #include <linux/mutex.h>
> #include <linux/slab.h>
> #include <linux/io.h>
> +#include <linux/leds.h>
> #include "../../firmware/dcdbas.h"
> #include "dell-smbios.h"
>
> @@ -40,6 +41,9 @@ static int da_command_code;
> static int da_num_tokens;
> static struct calling_interface_token *da_tokens;
>
> +struct led_classdev *dell_kbd_backlight_led;
> +EXPORT_SYMBOL_GPL(dell_kbd_backlight_led);
> +
> int dell_smbios_error(int value)
> {
> switch (value) {
This is ugly! dell-smbios.c file have nothing to do with led and
keyboard backlight. It is generic interface for sending and receiving
smbios requests.
I know, there are "layering problems" and something better should be
invented. Drivers dell-wmi.ko and dell-rbtn.ko provides events and
dell-laptop.ko want to listen for them. There is already hack in
dell-rbnt.ko which I really would like to fix and then delete...
So I rather do not want to see another hacks in that code.
--
Pali Rohár
pali.rohar@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
