> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Monday, September 12, 2016 9:13 AM > To: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > Cc: tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; hpa@xxxxxxxxx; > davem@xxxxxxxxxxxxx; geert@xxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; > kvalo@xxxxxxxxxxxxxx; mchehab@xxxxxxxxxx; linux@xxxxxxxxxxxx; > x86@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; platform-driver- > x86@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx > Subject: Re: [patch v1] x86/platform/mellanox: introduce support for Mellanox > systems platform > > On Mon, Sep 12, 2016 at 06:29:58AM +0000, vadimp@xxxxxxxxxxxx wrote: > > From: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > > > > Enable system support for the Mellanox Technologies platform, which > > provides support for the next Mellanox basic systems: "msx6710", > > "msx6720", "msb7700", "msn2700", "msx1410", "msn2410", "msb7800", > > "msn2740", "msn2100" and also various number of derivative systems > > from the above basic types. > > What does "system support" mean? > > Why can't this just be a "normal" PCI driver, as you are just accessing a PCI > device and doing something with it, seems odd to claim it is a "platform" driver. > This driver also activates probes to create i2c platform driver and muxes. For ARM and PPC based systems I can activate such stuff through dts. To be honest I don't know what is the right way to do such things for x86 systems. If I will move PCI related stuff to separate driver, could you suggest some right location for that? For example, could I have the code like in f.e. in arch/x86/platform/ts5500/ts5500.c as a platform initialization code? Thanks, Vadim. > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
