2. August 2016 14:29 Uhr, "Baole Ni" <baolex.ni@xxxxxxxxx> schrieb: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> > Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> Acked-by: Peter Feuerer <peter@xxxxxxxx> > --- > drivers/platform/x86/acerhdf.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c > index 460fa67..a4706dd 100644 > --- a/drivers/platform/x86/acerhdf.c > +++ b/drivers/platform/x86/acerhdf.c > @@ -96,13 +96,13 @@ static struct platform_device *acerhdf_dev; > > module_param(kernelmode, uint, 0); > MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off"); > -module_param(interval, uint, 0600); > +module_param(interval, uint, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(interval, "Polling interval of temperature check"); > -module_param(fanon, uint, 0600); > +module_param(fanon, uint, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(fanon, "Turn the fan on above this temperature"); > -module_param(fanoff, uint, 0600); > +module_param(fanoff, uint, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(fanoff, "Turn the fan off below this temperature"); > -module_param(verbose, uint, 0600); > +module_param(verbose, uint, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(verbose, "Enable verbose dmesg output"); > module_param_string(force_bios, force_bios, 16, 0); > MODULE_PARM_DESC(force_bios, "Force BIOS version and omit BIOS check"); > -- > 2.9.2 -- thanks, --peter; -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
