I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>
Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx>
---
drivers/platform/x86/msi-laptop.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
index 4231770..8d9dc0e 100644
--- a/drivers/platform/x86/msi-laptop.c
+++ b/drivers/platform/x86/msi-laptop.c
@@ -534,17 +534,17 @@ static ssize_t store_auto_fan(struct device *dev,
return count;
}
-static DEVICE_ATTR(lcd_level, 0644, show_lcd_level, store_lcd_level);
-static DEVICE_ATTR(auto_brightness, 0644, show_auto_brightness,
+static DEVICE_ATTR(lcd_level, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, show_lcd_level, store_lcd_level);
+static DEVICE_ATTR(auto_brightness, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, show_auto_brightness,
store_auto_brightness);
-static DEVICE_ATTR(bluetooth, 0444, show_bluetooth, NULL);
-static DEVICE_ATTR(wlan, 0444, show_wlan, NULL);
-static DEVICE_ATTR(threeg, 0444, show_threeg, NULL);
-static DEVICE_ATTR(touchpad, 0444, show_touchpad, NULL);
-static DEVICE_ATTR(turbo_mode, 0444, show_turbo, NULL);
-static DEVICE_ATTR(eco_mode, 0444, show_eco, NULL);
-static DEVICE_ATTR(turbo_cooldown, 0444, show_turbo_cooldown, NULL);
-static DEVICE_ATTR(auto_fan, 0644, show_auto_fan, store_auto_fan);
+static DEVICE_ATTR(bluetooth, S_IRUSR | S_IRGRP | S_IROTH, show_bluetooth, NULL);
+static DEVICE_ATTR(wlan, S_IRUSR | S_IRGRP | S_IROTH, show_wlan, NULL);
+static DEVICE_ATTR(threeg, S_IRUSR | S_IRGRP | S_IROTH, show_threeg, NULL);
+static DEVICE_ATTR(touchpad, S_IRUSR | S_IRGRP | S_IROTH, show_touchpad, NULL);
+static DEVICE_ATTR(turbo_mode, S_IRUSR | S_IRGRP | S_IROTH, show_turbo, NULL);
+static DEVICE_ATTR(eco_mode, S_IRUSR | S_IRGRP | S_IROTH, show_eco, NULL);
+static DEVICE_ATTR(turbo_cooldown, S_IRUSR | S_IRGRP | S_IROTH, show_turbo_cooldown, NULL);
+static DEVICE_ATTR(auto_fan, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, show_auto_fan, store_auto_fan);
static struct attribute *msipf_attributes[] = {
&dev_attr_bluetooth.attr,
--
2.9.2
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
