On Mon, Jul 04, 2016 at 03:01:33PM +0300, Andy Shevchenko wrote: > On Mon, 2016-07-04 at 17:05 +0530, Rajneesh Bhardwaj wrote: > > > > > > > > > So, if there is no objections (taking into consideration minors you > > > mentioned) I think the patch can be applied. > > > > > > > --- a/drivers/platform/x86/intel_pmc_core.c > > +++ b/drivers/platform/x86/intel_pmc_core.c > > @@ -23,6 +23,7 @@ > > #include <linux/init.h> > > #include <linux/io.h> > > #include <linux/pci.h> > > +#include <linux/seq_file.h> > > What is this for? > At this point it may be redundant as there will be no consumer for this. We may add it later when it's needed for seq_printf / seq_* etc. So i think we might just do away with this for v2. > > > > #include <asm/cpu_device_id.h> > > #include <asm/intel-family.h> > > @@ -88,7 +89,8 @@ static int pmc_core_dev_state_get(void *data, u64 > > *val) > > return 0; > > } > > > > -DEFINE_DEBUGFS_ATTRIBUTE(pmc_core_dev_state, pmc_core_dev_state_get, > > NULL, > > "%llu"); > > +DEFINE_DEBUGFS_ATTRIBUTE(pmc_core_dev_state, pmc_core_dev_state_get, > > NULL, > > + "%llu\n"); > > Okay, since debugfs is actually using them in standard code, we may add > it here as well. > > > --- a/drivers/platform/x86/intel_pmc_core.h > > +++ b/drivers/platform/x86/intel_pmc_core.h > > @@ -29,7 +29,6 @@ > > #define SPT_PMC_MMIO_REG_LEN 0x100 > > #define SPT_PMC_SLP_S0_RES_COUNTER_STEP 0x64 > > > > -struct dentry; > > Agreed. > > -- > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Intel Finland Oy -- Best Regards, Rajneesh -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
