On Wed, Jun 29, 2016 at 09:02:11AM +0930, Jonathan Woithe wrote: > Hi Darren > > In the "Add support for eco LED" thread you noted: > > > I was going to point out the checkpatch failures in codingstyle, but you > > were probably as consistent as you could be given the state of this driver > > and it's rather inconsistent use of whitespace. > > It is true that there is inconsistency in this regard within this driver, > which has come about for various historical reasons. Would you take a pure > whitespace cleanup patch if I were to go through the driver and fix these > issues as best they can be? Yes, I'm happy to take those. I know some maintainers prefer not to take non-functional changes as they make git blame less immediately useful (for example), but I prefer for existing code to be compliant with CodingStyle, or it tends to spread through new patches such as this one for the sake of internal consistency. So yes, I'd gladly take a whitespace cleanup patch. Thanks for offering. Thanks, -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
