On Tue, Jun 21, 2016 at 11:01:01PM -0700, Guenter Roeck wrote: > On 06/21/2016 09:53 PM, Yong, Jonathan wrote: > > On 06/17/2016 08:36, Yong, Jonathan wrote: > > > These patches fix the iTCO watchdog for Apollo Lake. > > > I changed the watchdog memory io to only use 4 bytes rather > > > the whole region, I'm not sure if that is the correct way. > > > > > > The previous 0x30h offset in intel_pmc_ipc.c was for based > > > on the earlier BXT-M platform. Apollo Lake has it at 0x40h. > > > > > > Let me know if the patches need changes. > > > Please CC me as I am not subscribed, thanks. > > > > > > * Resent, typo in linux-kernel email address > > > > > > Changes since v1: > > > * Watchdog NO_REBOOT bit off-by-one corrected. > > > > > > Yong, Jonathan (2): > > > watchdog: iTCO-wdt handle 5th variation for Apollo Lake > > > x86: Fix Apollo Lake Watchdog address in PMC driver > > > > > > drivers/platform/x86/intel_pmc_ipc.c | 10 ++++++---- > > > drivers/watchdog/iTCO_wdt.c | 2 ++ > > > 2 files changed, 8 insertions(+), 4 deletions(-) > > > > > > > Ping. > > > > > Waiting for an Ack from Darren. Jonathan verified that the change will not break existing external platforms. I'm happy with it from that perspective. Guenter, will you take both patches together? Reviewed-by: Darren Hart <dvhart@xxxxxxxxxxxxxxx> -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
