On Mon 2016-06-13 17:10:02, João Paulo Rechi Vita wrote: > On 13 June 2016 at 17:01, Pavel Machek <pavel@xxxxxx> wrote: > > On Mon 2016-06-13 15:59:35, João Paulo Rechi Vita wrote: > >> On 13 June 2016 at 15:00, Pavel Machek <pavel@xxxxxx> wrote: > >> > Hi! > >> > > >> >> > João, that means you should send a patch to add the ::rfkill suffix. > >> >> > > >> >> > >> >> IMO "airplane" (or maybe "airplane-mode") is a better suffix, as it > >> >> reflects the label on the machine's chassis. I'll name it > >> >> "asus-wireless::airplane" and send this through platform-drivers-x86, > >> >> as this is now contained in the platform-drivers-x86 subsystem. Thanks > >> >> Johannes for your patience and help designing and reviewing the rfkill > >> >> changes, even if not all of them made it through in the end. And > >> >> thanks everyone else involved for the feedback. > >> > > >> > Actually, I'd do '::rfkill', for consistency with other places in > >> > /sys. > >> > > >> > /sys/devices/platform/thinkpad_acpi/rfkill/rfkill1/name > >> > /sys/class/rfkill > >> > /sys/module/rfkill > >> > > >> > >> If we use "rfkill" as a suffix, how do you expect userspace to be able > >> to differentiate between a LED that indicates airplane-mode (LED ON > >> when all radios are OFF) and a LED that indicates the state of a > >> specific radio like WiFi or Bluetooth (LED ON when that specific radio > >> is ON)? If we're going this route we should provide meaningful > >> information here. > > > > '::airplane' has same problem, no? > > > > No, because in this case we would not use "airplane" as a suffix for a > LED associated with an individual radio. > > > If you want to distinguish that, maybe you can do '::rfkill' for > > everything vs '::rfkill-wifi' for wifi-only and '::rfkill-bt' for > > bluetooth... > > > > The problem here is that the "rfkill" name is already associated with > individual rfkill switches under /sys/class/rfkill, > /sys/devices/platform/*/rfkill etc, so I think we're better off > distinguishing "airplane" vs "wifi" vs "bluetooth" etc, to avoid > confusion. (Actually, "::wifi" is super confusing, I'd expect that to be a led that blinks when wifi is active.) Well... "airplane" is quite confusing. I'd we use "rfkill" for disabling radios, and I believe we should stick with that. But small problem might be polarity. You may need both "::rfkill" and "::not-rfkill". Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
