On Thu, May 12, 2016 at 12:34:05AM +0300, Denis Gordienko wrote: > Hi, Darren. This patch already tested on my laptop and I can confirm - it's > work fine. Awesome, thanks! Added your tested-by. > Denis > 11 Май 2016 г. 23:09 пользователь "Darren Hart" <dvhart@xxxxxxxxxxxxx> > написал: > > On Mon, May 09, 2016 at 11:49:21PM +0200, Arnd Bergmann wrote: > > My patch to the ideapad-laptop driver to get the ESC key working on the > > Yoga 1170 (Yoga 3) failed to do the same for the following model, the > > Lenovo Yoga 700. > > > > Denis Gordienko managed to get it working by adding another GUID for the > > new WMI interface. I have adapted his patch to normal coding style > > and simplified it a bit for inclusion, but this patch is currently > > untested. > > > > Link: > https://forums.lenovo.com/t5/Lenovo-Yoga-Series-Notebooks/YOGA-3-14-How-to-reclaim-my-Esc-key-and-permanently-disable/m-p/3317499 > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > Cc: Denis Gordienko <denis.gordienko.mail@xxxxxxxxx> > > Looks good to me, but of course I would like to see some testing. Denis, I > presume you have a Yoga 700 you could verify this version of your patch on? > Would you be willing to do so? > > > > --- > > drivers/platform/x86/ideapad-laptop.c | 19 ++++++++++++++++--- > > 1 file changed, 16 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/platform/x86/ideapad-laptop.c > b/drivers/platform/x86/ideapad-laptop.c > > index 1d49db124753..531ecca9dbe3 100644 > > --- a/drivers/platform/x86/ideapad-laptop.c > > +++ b/drivers/platform/x86/ideapad-laptop.c > > @@ -48,7 +48,10 @@ > > #define CFG_CAMERA_BIT (19) > > > > #if IS_ENABLED(CONFIG_ACPI_WMI) > > -static const char ideapad_wmi_fnesc_event[] = > "26CAB2E5-5CF1-46AE-AAC3-4A12B6BA50E6"; > > +static const char* ideapad_wmi_fnesc_events[] = { Arnd, should this be: static const char *const ideapad_wmi_fnesc_events[] = { ? Checkpatch complains, I see both usages throughout the kernel. I believe we do want a const array of const char arrays, so I think this is a better declaration. Any objection to this change? -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
