On Thu, Feb 25, 2016 at 11:45:28AM +0100, Pali Rohár wrote: > On Tuesday 23 February 2016 09:35:47 Andy Lutomirski wrote: > > On Feb 23, 2016 4:01 AM, "Pali Rohár" <pali.rohar@xxxxxxxxx> wrote: > > > > > > On Wednesday 17 February 2016 07:07:28 Mario Limonciello wrote: > > > > > > > > > > > > On 02/17/2016 05:16 AM, Pali Rohár wrote: > > > > > On Monday 15 February 2016 08:32:37 Andy Lutomirski wrote: > > > > >> On the XPS 13 9350, the dell-rbtn mechanism has a new device id, and > > > > >> the DSDT turns it off if a new enough _OSI is supported. Add a > > > > >> comment about why we don't bother supporting it. > > > > >> > > > > >> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx> > > > > >> --- > > > > >> drivers/platform/x86/dell-rbtn.c | 15 +++++++++++++++ > > > > >> 1 file changed, 15 insertions(+) > > > > >> > > > Andy, can you look at it and try identify where is the problem? > > > > I think it's straightforward. If we identify as Windows 7 and enable > > this driver then, when we press the wireless button, dell-rbtn > > switches its state *and* NetworkManager gets KEY_RFKILL from intel-hid > > and changes its state. Then you can tell NetworkManager to turn wifi > > on using the menu, at which point dell-rbtn is off but NM's software > > state is on. Then you press the button again, turning on dell-rbtn > > but turning NM off again. The result is that the last button press > > direct work as expected. > > > > I haven't verified that this is actually what happens, but it's > > certainly the case that a button that triggers a state toggle should > > only change the state by *one* mechanism. > > > > Presumably this works on Windows 7 because either there is no > > equivalent of intel-hid or because the DSDT turns it off -- I haven't > > checked which is the case. > > > > --Andy > > Understood, this is just big API mess in Dell APCI/EC/firmware and also > our kernel implementation in (dell-(laptop|wmi|rbtn)|intel-hid) drivers > is not ideal and clean... > > Darren, add my Acked-by also for this patch (if you already have not > done it). This is done and in next already. > > -- > Pali Rohár > pali.rohar@xxxxxxxxx > -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
