On Mon, Feb 15, 2016 at 06:37:16PM +0100, Pali Rohár wrote:
> On Monday 15 February 2016 18:26:24 Mario Limonciello wrote:
> > On 02/15/2016 11:20 AM, Pali Rohár wrote:
> > > On Monday 15 February 2016 17:32:36 Andy Lutomirski wrote:
> > >> + /* Stealth mode toggle */
> > >> + { KE_IGNORE, 0x155, { KEY_RESERVED } },
> > >
> > > Hi! Just one question, what does this "Stealth mode" means and what
> > > this toggle key/button doing?
> > >
> > > I would propose for Laptops manufactures to revert back normal
> > > nonchiclet keyboard with full 105 normal keys (with F1-F12) instead
> > > inventing such useless and crappy/funny names for keys/buttons on
> > > laptops which replace PgUP/PgDown/SysRq and etc...
> >
> > Pali,
> >
> > Stealth mode will "disable all lights and sounds". The event is for
> > notification only. The actual change is performed by a combination
> > of the BIOS and EC.
> >
> > There is also a BIOS setting that disables the hotkey from doing
> > anything.
> >
> > Thanks,
>
> Thank you! Now I can image what this line in diff means :-)
>
> Anyway, I would propose some rule to and longer description for newly
> invented hot key events which are marked as KEY_RESERVED in kernel
> source code. Really sometimes it is hard to guess what it can means and
> constant KEY_RESERVED does not help much more.
Since we got the update from Mario, could you include the "disable all lights
and sounds" blurb in the KEY_RESERVED comment for stealth mode as part of the
next spin.
Pali, is that your only concern with this series?
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
