On Monday 08 February 2016 13:42:10 Darren Hart wrote: > Assuming the above is an accurate view, I don't see any reason to go beyond the > minimal change to the existing SMBIOS code to make it a usable API. If the need > arises, we can always make such optimizations and performance improvements > later. This is an internal API and we can change it whenever we need to so long > as we update the call sites. Problem is that now smbios code from dell-laptop.c is moved into dell-smbios.c and dell-smbios.h and LED subsystem starts using dell-smbios.h. In this case I'm thinking that we have something like API usable by other modules/subsystem. And I'm thinking if it is not better to create "correct" API now instead rewriting code in LED and platform subsystem again later... As this API needs to provide just 1 function, send command to Dell SMBIOS I think that API is still minimal. Currently we have another two functions alloc/free buffer (needed for send). -- Pali Rohár pali.rohar@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
