On Sat, Jan 30, 2016 at 09:45:45AM -0800, Darren Hart wrote: > On Sat, Jan 30, 2016 at 09:17:47AM -0800, Andy Lutomirski wrote: > > On Sat, Jan 30, 2016 at 9:04 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote: > > > On Wed, Jan 20, 2016 at 12:46:23PM -0800, Andy Lutomirski wrote: > > >> On Wed, Jan 20, 2016 at 11:40 AM, Pali Rohár <pali.rohar@xxxxxxxxx> wrote: > > >> > On Tuesday 19 January 2016 15:07:47 Andy Lutomirski wrote: > > >> >> The XPS 13 9350 sends WMI keypress events that aren't enumerated in > > >> >> the DMI table. Add a table listing them. To avoid breaking things > > >> >> that worked before, these un-enumerated hotkeys won't be used if the > > >> >> DMI table maps them to something else. > > >> >> > > >> >> FWIW, it appears that the DMI table may be a legacy thing and we > > >> >> might want to rethink how we handle events in general. As an > > >> >> example, a whole lot of things map to KEY_PROG3 via the DMI table. > > >> >> > > >> >> So far, this doesn't send keypress events for any of the new > > >> >> events. Depnding on whether we figure out exactly what needs to > > >> >> happen to get the wireless button working in time for Linux 4.5, > > >> >> we might want to temporarily handle it in dell-wmi. > > >> >> > > >> >> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx> > > >> > > > >> > Looks good, > > >> > > > >> > Reviewed-by: Pali Rohár <pali.rohar@xxxxxxxxx> > > >> > > >> Darren, if/when you apply this, can you fix up the last paragraph of > > >> the commit message? > > >> > > >> This doesn't send keypress events for any of the new > > >> events, as no models appear to require it. > > >> > > >> I wrote the old text before intel-hid landed. > > >> > > >> --Andy > > > > > > This had some problems applying to 4.5-rc1 (refactoring of handle_dmi_...). I've > > > done the merge, it builds, but I can't test it. Please have a look at the > > > dell-wmi branch and let me know if this is correct and working as expected. > > > > > > > It's probably okay, but I think you applied it out of order. This > > patch was intended to be applied after the handle_dmi_xyz fixes. If > > you back this one out, apply those, and then re-apply this, it should > > apply cleanly. > > > > --Andy > > Ah, thanks. Sometimes that gets lost in the INBOX, I was starting to think the > same thing as I went through the patchwork list though. I'll back it out and do > that. Thanks! Turns out I wasn't Cc'd on the dependent dmi fixes series. Please include me on Cc for patches where I show up as a maintainer. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
