> For full support we need: > > 1) invoke special SMBIOS call for some machine > > 2) patch dell-wmi.c to do not drop some events for some machines > > Part 2) needs to touch only dell-wmi.c code, this is obvious. But I > thought that part 1) will be done in dell-laptop.c code where are all > others SMBIOS calls. Reason is just because dell-wmi.c is doing WMI > stuff. Do you want to include this is part 1) also to dell-wmi.c file? Yes, that was my idea. That SMBIOS call is basically WMI initialization code. Consider the case of Vostro V131 - there is no WMI on that machine without that SMBIOS call and there is no need to issue that SMBIOS call if you don't want to use WMI. Given that dell-wmi does not depend on dell-laptop, consider the extreme case where the user selects CONFIG_DELL_LAPTOP=n and CONFIG_DELL_WMI=m, expecting WMI to work. If we put the WMI-enabling SMBIOS call in dell-laptop, it won't. Also, once my Dell SMBIOS API rework series gets applied, adding the relevant call to dell-wmi will be easy. -- Best regards, Michał Kępień -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
